Final improvement in accepted clause
#583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After some thought, I believe that the compiler maintainers have a better judgement of when proposals can be merged, especially because of the compatibility guarantees that the Scala compiler contract enforces. In this way, I propose that the Compiler team chooses the most appropriate version to include the accepted proposal.
|
When changing the wording of the SIP document, which most people have already agreed with, I think it's best not to merge until someone (me, Seth, just anyone else on the SIP committee) has reviewed your changes. |
|
Hi @heathermiller! Jorge has dropped by my office today in the afternoon, and we discussed this change. I agreed that it's a good idea, but didn't put a formal LGTM before the merge. I will be more rigorous in the future. |
|
I will try to be more rigorous in the future as well, @heathermiller. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some thought, I believe that the compiler maintainers have a
better judgement of when proposals can be merged, especially because of
the compatibility guarantees that the Scala compiler contract enforces.
In this way, I propose that the Compiler team chooses the most
appropriate version to include the accepted proposal.